Fetch module service worker scripts with same-origin credentials#1829
Merged
yoshisatoyanagisawa merged 1 commit intoJun 22, 2026
Merged
Conversation
Collaborator
Author
|
@yoshisatoyanagisawa CYTAL? |
github-actions Bot
added a commit
that referenced
this pull request
Jun 22, 2026
SHA: 2fd367a Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1365.
The Update algorithm passed
"omit"as the credentials mode when fetchingmodule service worker scripts. HTML changed module scripts to default to
"same-origin"in whatwg/html@5fabb58, and service workersdon't expose a way to opt back into
"omit".This change updates the call to
fetch a module worker script graphtopass
"same-origin", aligning the spec with HTML and with shippingbrowser behavior.
Preview | Diff