fix(check): stop multi check from hanging on exit after a run completes#151
Open
RobbieMcKinstry wants to merge 1 commit into
Open
fix(check): stop multi check from hanging on exit after a run completes#151RobbieMcKinstry wants to merge 1 commit into
multi check from hanging on exit after a run completes#151RobbieMcKinstry wants to merge 1 commit into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…etes `Check::dispatch()` only called `std::process::exit` on the failure path; a successful run fell through to an implicit `Runtime` drop, which blocks until every task the runtime ever spawned — ours or a dependency's — has fully unwound. Any straggling task (e.g. deep inside cersei-agent/-provider) could silently hold the process open after the presenter had already torn down and printed the record, requiring Ctrl-C to exit. Also stop `discovery`, `execution`, and `reporting` explicitly (mirroring the presenter's existing stop_gracefully/wait_for_shutdown pattern) instead of just dropping their ActorRefs — ExecutionActor's per-check background tasks hold their own clones of those refs, so implicit ref-counted mailbox closure was a race against those tasks finishing rather than a deterministic signal. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
RobbieMcKinstry
force-pushed
the
fix-multi-check-hang-on-exit
branch
from
77e8f80 to
bbdedc8
Compare
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check::dispatch()only calledstd::process::exiton the failure path;a successful run fell through to an implicit
Runtimedrop, which blocksuntil every task the runtime ever spawned — ours or a dependency's — has
fully unwound. Any straggling task (e.g. deep inside cersei-agent/-provider)
could silently hold the process open after the presenter had already torn
down and printed the record, requiring Ctrl-C to exit.
Also stop
discovery,execution, andreportingexplicitly (mirroringthe presenter's existing stop_gracefully/wait_for_shutdown pattern) instead
of just dropping their ActorRefs — ExecutionActor's per-check background
tasks hold their own clones of those refs, so implicit ref-counted mailbox
closure was a race against those tasks finishing rather than a deterministic
signal.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com