Handle emoji selector (variant selector 16)#292
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 47 47
Lines 3950 3952 +2
Branches 658 660 +2
=====================================
+ Hits 3340 3342 +2
Misses 450 450
Partials 160 160 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle Variant Selector 16 (VS16) correctly. If VS16 is present, the character is rendered as an emoji and will display as 2 columns in the terminal.
Note that this is getting into terminal-specific behavior -- but I think following the way that modern terminals display emoji is the best path.
https://en.wikipedia.org/wiki/Variation_Selectors_(Unicode_block)