Allow devise-jwt to be used with devise 5.0.0.rc#291
Merged
waiting-for-dev merged 1 commit intowaiting-for-dev:mainfrom Jan 13, 2026
Merged
Allow devise-jwt to be used with devise 5.0.0.rc#291waiting-for-dev merged 1 commit intowaiting-for-dev:mainfrom
devise-jwt to be used with devise 5.0.0.rc#291waiting-for-dev merged 1 commit intowaiting-for-dev:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
devisedependency to allow installation with5.0.0.rc. This addresses #290 and is more constrained than #275 (which would allow a future v6, v7 and so on).With this change, the existing
devise-jwtunit tests are passing with the updated version ofdevise; reviewing https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#500rc---2025-12-31, it doesn't appear that any of its breaking changes affectdevise-jwt.There is the potential for other breaking changes to be introduced in a future
5.0.0final release, though the same could be said of any hypothetically buggy5.0.1or above. If this is a concern, the version restriction could temporarily become'>= 4.0.0', '<= 5.0.0.rc'.