perf: cache workspace typechecks with Vite Task - #1
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Scope checkThis PR changes 1,142 lines across 2 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dc1021b8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "description": "Agent-portable reimplementation of WordPress on Astro", | ||
| "scripts": { | ||
| "typecheck": "pnpm run --filter {./packages/**} typecheck", | ||
| "typecheck": "vp run --cache --parallel --concurrency-limit 4 --filter \"./packages/**\" typecheck", |
There was a problem hiding this comment.
Require a Node version supported by Vite+
This new typecheck script now invokes vp, but the workspace still advertises engines.node: ">=22" while vite-plus@0.2.2 in the lockfile requires ^20.19.0 || ^22.18.0 || >=24.11.0 (pnpm-lock.yaml:11874-11876). A contributor or CI image pinned to Node 22.0–22.17 satisfies this repo's engine range but is outside the supported runtime for the tool that now runs every package typecheck, so the advertised setup can no longer run pnpm typecheck; either keep the old runner or raise the workspace engine to match Vite+.
Useful? React with 👍 / 👎.
What does this PR do?
Caches package typechecks through Vite Task content tracking and adds the project-local Vite+ 0.2.2 dependency. This fork-local PR exists to measure CI behavior and is not intended for the official repository.
Closes # N/A
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change) — N/A: private-workspace tooling onlypnpm formathas been runAI-generated code disclosure
Screenshots / test output
vp run -w typecheck: 27/27 cache hits on a warm local run, about 10.15s reported savedvp run -w lintvp run -w format:checkpnpm install --frozen-lockfile