Skip to content

perf: cache workspace typechecks with Vite Task - #1

Open
wan9chi wants to merge 12 commits into
mainfrom
perf/cache-typecheck-vite-task
Open

perf: cache workspace typechecks with Vite Task#1
wan9chi wants to merge 12 commits into
mainfrom
perf/cache-typecheck-vite-task

Conversation

@wan9chi

@wan9chi wan9chi commented Jul 6, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Caches package typechecks through Vite Task content tracking and adds the project-local Vite+ 0.2.2 dependency. This fork-local PR exists to measure CI behavior and is not intended for the official repository.

Closes # N/A

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change) — N/A: private-workspace tooling only
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable) — N/A: command-only change
  • User-visible strings in the admin UI are wrapped for translation (if applicable) — N/A: no UI changes
  • I have added a changeset (if this PR changes a published package) — N/A: private root workspace only
  • New features link to an approved Discussion — N/A: no feature

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool: OpenAI GPT-5.6 via OpenCode

Screenshots / test output

  • vp run -w typecheck: 27/27 cache hits on a warm local run, about 10.15s reported saved
  • vp run -w lint
  • vp run -w format:check
  • pnpm install --frozen-lockfile

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Scope check

This PR changes 1,142 lines across 2 files. Large PRs are harder to review and more likely to be closed without review.

If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs.

See CONTRIBUTING.md for contribution guidelines.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9dc1021b8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"description": "Agent-portable reimplementation of WordPress on Astro",
"scripts": {
"typecheck": "pnpm run --filter {./packages/**} typecheck",
"typecheck": "vp run --cache --parallel --concurrency-limit 4 --filter \"./packages/**\" typecheck",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require a Node version supported by Vite+

This new typecheck script now invokes vp, but the workspace still advertises engines.node: ">=22" while vite-plus@0.2.2 in the lockfile requires ^20.19.0 || ^22.18.0 || >=24.11.0 (pnpm-lock.yaml:11874-11876). A contributor or CI image pinned to Node 22.0–22.17 satisfies this repo's engine range but is outside the supported runtime for the tool that now runs every package typecheck, so the advertised setup can no longer run pnpm typecheck; either keep the old runner or raise the workspace engine to match Vite+.

Useful? React with 👍 / 👎.

@wan9chi wan9chi closed this Jul 6, 2026
@wan9chi wan9chi reopened this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant