Skip to content

fix(input): heading base-font bold + list-item spacing guard #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wildseansy wants to merge 1 commit into from
Closed

fix(input): heading base-font bold + list-item spacing guard #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/react-native-enriched-markdown/ios/input/ENRMInputFormatter.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,22 @@ - (UIFont *)headingFontForLevel:(NSInteger)level
}

NSString *weightString = _headingFontWeights[level];
UIFont *font = weightString.length > 0 ? [UIFont systemFontOfSize:size weight:ENRMFontWeightFromString(weightString)]
: [_baseFont fontWithSize:size];
UIFont *font;
if (weightString.length > 0 && ENRMFontWeightFromString(weightString) >= UIFontWeightBold) {
// Derive the bold face of the base (content) font — matching Android's
// InputHeadingSpan, which folds heading weight into the current typeface —
// so a custom editor font keeps its family in headings. Fall back to the
// system font only when the family has no bold face.
UIFont *sized = [_baseFont fontWithSize:size];
UIFontDescriptor *descriptor = [sized.fontDescriptor
fontDescriptorWithSymbolicTraits:sized.fontDescriptor.symbolicTraits | UIFontDescriptorTraitBold];
font = descriptor ? [UIFont fontWithDescriptor:descriptor size:size]
: [UIFont systemFontOfSize:size weight:UIFontWeightBold];
} else if (weightString.length > 0) {
font = [UIFont systemFontOfSize:size weight:ENRMFontWeightFromString(weightString)];
} else {
font = [_baseFont fontWithSize:size];
}
_headingFontCache[level] = font;
return font;
}
Expand Down