Skip to content

AFDocs fixes: avoid redirect-behavior false positive in anchor copy handler #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rachaelrenk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

AFDocs fixes: avoid redirect-behavior false positive in anchor copy handler #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb0bd6
AFDocs fixes: avoid redirect-behavior false positive in anchor copy h…
rachaelrenk May 22, 2026
bf28301
Merge branch 'main' into afdocs-fix-redirect-behavior
rachaelrenk May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/CustomHead.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ const fontsHref =
history.pushState(null, '', url);
showCopiedFeedback(anchor);
} catch {
window.location.href = href;
// Navigate to the anchor fragment. Avoids `window.location.href = …`
// which the afdocs redirect-behavior check misclassifies as a JS
// redirect (it heuristically scans for location.href assignments in
// the first 10 KB of HTML).
window.location.hash = url.hash;
Comment on lines +112 to +116
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This comment still includes the location.href = pattern the AFDocs checker scans for, so the redirect-behavior false positive can remain.

Suggested change
// Navigate to the anchor fragment. Avoids `window.location.href = …`
// which the afdocs redirect-behavior check misclassifies as a JS
// redirect (it heuristically scans for location.href assignments in
// the first 10 KB of HTML).
window.location.hash = url.hash;
// Navigate to the anchor fragment without using href-based
// navigation, which the afdocs redirect-behavior check
// misclassifies as a JS redirect when scanned in inline scripts.
window.location.hash = url.hash;

}
});
</script>
Expand Down
Loading