Skip to content

ian/default_proxy_env_vars_direct_backend #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianhodge wants to merge 1 commit into from
Closed

ian/default_proxy_env_vars_direct_backend #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/worker/direct.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,16 @@ const defaultWorkspaceRoot = "/var/lib/oz/workspaces"
// defaultInheritedEnvVars are the host environment variables passed through to
// tasks and scripts by default. Sensitive worker credentials are intentionally
// excluded; additional variables can be opted in via the backend config.
var defaultInheritedEnvVars = []string{"HOME", "TMPDIR", "PATH"}
// Proxy variables are included so the oz CLI can route traffic through HTTP
// proxies configured on the host (e.g. egress proxies in restricted networks).
var defaultInheritedEnvVars = []string{
"HOME", "TMPDIR", "PATH",
// HTTP proxy configuration (both cases for portability).
"HTTPS_PROXY", "https_proxy",
"HTTP_PROXY", "http_proxy",
"ALL_PROXY", "all_proxy",
"NO_PROXY", "no_proxy",
}

// hostBaseEnv builds a minimal env slice from the host, containing only the
// keys listed in defaultInheritedEnvVars.
Expand Down
Loading