Inherit proxy env vars by default in direct backend#40
Closed
Conversation
Add HTTP_PROXY, HTTPS_PROXY, NO_PROXY, ALL_PROXY (and lowercase variants) to defaultInheritedEnvVars so the oz CLI automatically inherits the worker's proxy configuration. Previously, customers had to explicitly configure proxy env vars in the backend.direct.environment config. While that still works as an override, inheriting them by default is the expected behavior for proxy-aware environments. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add standard proxy environment variables (
HTTP_PROXY,HTTPS_PROXY,NO_PROXY,ALL_PROXYand lowercase variants) todefaultInheritedEnvVarsin the direct backend.Previously, only
HOME,TMPDIR, andPATHwere inherited from the host process environment. Customers behind HTTP CONNECT proxies had to explicitly configure proxy env vars inbackend.direct.environment, which is error-prone and non-obvious.With this change, the oz CLI automatically inherits the worker's proxy settings. Explicit config entries still work as overrides.
Related: This is the companion fix to warpdotdev/warp-internal#23747 which fixes a port parsing bug in the websocket proxy code. Both fixes are needed to fully resolve the customer issue.
Testing
go build ./...succeedsgo test ./...— all tests passConversation: https://staging.warp.dev/conversation/5cb48f52-5908-4cb5-bde3-3e5ce5dce30c
Run: https://oz.staging.warp.dev/runs/019d4076-25fb-78e4-ab78-459000d0cb34
This PR was generated with Oz.