add generalized virtualized viewport element#13177
Merged
Merged
Conversation
This was referenced Jun 29, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
harryalbert
force-pushed
the
harry/tui-viewport-element
branch
2 times, most recently
from
40dbb8a to
f2ab35d
Compare
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
harryalbert
changed the title
harryalbert
changed the title
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds a generalized TUI virtualized viewport stack, including clipping, wheel-scroll wrapping, mouse event conversion, a demo harness, tests, and an accompanying technical spec. I reviewed the attached annotated diff, PR description, and spec context; no approved repository spec context was available for implementation matching.
Concerns
- No blocking correctness, security, error-handling, or performance concerns found in the changed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
force-pushed
the
harry/tui-viewport-element
branch
from
707ebfa to
d914567
Compare
harryalbert
changed the title
Adds a content-agnostic TUI viewport stack (TuiViewportedList, TuiViewportIndex/Cursor, TuiScrollable, TuiText vertical scroll, and mouse-wheel event conversion) plus an interactive warpui_core example (tui_viewport_demo) that exercises every component over a simple in-memory text-block index. No terminal/AI coupling. Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
harry/tui-viewport-element
branch
from
a2a99b5 to
9547813
Compare
harryalbert
force-pushed
the
harry/tui-viewport-element
branch
from
d49da1b to
99c98bf
Compare
kevinyang372
approved these changes
Jun 30, 2026
dagmfactory
pushed a commit
that referenced
this pull request
Jun 30, 2026
## Description
<!-- Please remember to add your design buddy onto the PR for review, if
it contains any UI changes! -->
This PR adds a generalized viewport element that takes caller-owned
ordered-height index/cursor, and handles rendering only the visible rows
in an efficient way (and keeping scroll position stable through
resizes). This viewport will serve as the backing element to render the
blocklist, without being blocklist-specific (any other caller could
provide a sum tree and set of items and get the same efficient rendering
for free). This PR also adds some smaller helpers to allow for
generalized item clipping and scrollable behavior, and handling for
scroll mouse events.
The big things to read in this PR are:
* crates/warpui_core/src/elements/tui/viewported_list.rs
* New generic virtualized list / viewport.
* crates/warpui_core/src/elements/tui/scrollable.rs
* New wheel-scroll wrapper.
* crates/warpui_core/src/elements/tui/clipped.rs
* New vertical row clipping wrapper.
* crates/warpui_core/src/runtime/event_conversion.rs
* Adds crossterm mouse/wheel conversion into Warp’s shared Event.
* crates/warpui_core/src/elements/tui/event.rs
* Changes TUI event context from queued “app updates” to view
notifications.
* crates/warpui_core/examples/tui_viewport_demo.rs
* Manual harness demonstrating the pieces together.
## Testing
<!--
How did you test this change? What automated tests did you add? If you
didn't add any new tests, what's your justification for not adding any?
Manual testing is required for changes that can be manually tested, and
almost all changes can be manually tested. If your change can be
manually tested, please include screenshots or a screen recording that
show it working end to end.
You can run the app locally using `./script/run` - see AGENTS.md for
more details on how to get set up.
-->
- [x] I have manually tested my changes locally with `./script/run`
### Screenshots / Videos
<!-- Attach screenshots or a short video demonstrating the change, where
appropriate. Remove this section if it is not relevant to your PR. -->
Running the demo added in this PR:
https://www.loom.com/share/dd626bbe4c2e470da975b44c5d80ab15
## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
---------
Co-authored-by: Oz <oz-agent@warp.dev>
This was referenced Jul 1, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a generalized viewport element that takes caller-owned ordered-height index/cursor, and handles rendering only the visible rows in an efficient way (and keeping scroll position stable through resizes). This viewport will serve as the backing element to render the blocklist, without being blocklist-specific (any other caller could provide a sum tree and set of items and get the same efficient rendering for free). This PR also adds some smaller helpers to allow for generalized item clipping and scrollable behavior, and handling for scroll mouse events.
The big things to read in this PR are:
Testing
./script/runScreenshots / Videos
Running the demo added in this PR:
https://www.loom.com/share/dd626bbe4c2e470da975b44c5d80ab15
Agent Mode