Add pinning flag to preview#13264
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR promotes PinnedTabs from Dogfood to Preview and adds a Preview changelog description for the flag.
Concerns
- This is a user-facing rollout, but the PR description does not include screenshots or a screen recording demonstrating tab pinning working end to end for Preview users.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| FeatureFlag::AsyncFind, | ||
| #[cfg(any(target_os = "macos", target_os = "windows"))] | ||
| FeatureFlag::DragTabsToWindows, | ||
| FeatureFlag::PinnedTabs, |
There was a problem hiding this comment.
johnturcoo
force-pushed
the
johnturco/app-4807-flip-pinning-flag-to-preview
branch
from
f7af3cc to
c0902a2
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR promotes PinnedTabs from dogfood to preview and adds a preview changelog description for the flag.
Concerns
- The rollout is user-facing, but the PR description does not include screenshots or a screen recording demonstrating tab pinning working end to end for preview users.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| FeatureFlag::AsyncFind, | ||
| #[cfg(any(target_os = "macos", target_os = "windows"))] | ||
| FeatureFlag::DragTabsToWindows, | ||
| FeatureFlag::PinnedTabs, |
There was a problem hiding this comment.
2 participants
Description
Switches tab pinning feature flag to preview.
Linked Issue
https://linear.app/warpdotdev/issue/APP-4808/switch-tab-pinning-to-preview