Fix tab renaming bug with tab groups in pane view#13289
Open
johnturcoo wants to merge 2 commits into
Open
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR hides tab-level rename/reset actions for grouped tabs in vertical-tabs Panes view and prevents the RenameActiveTab action from opening an editor when the active tab's top-level name is hidden.
Concerns
- No blocking correctness, security, or spec-drift concerns found. The PR includes visual evidence for the user-facing behavior.
- One nit is left inline for trailing whitespace.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In vertical-tabs Panes view, a tab that belongs to a tab group renders without its own header — only the individual pane rows (and their names) are shown, not the top-level tab name. This makes "Rename tab" / "Reset tab name" confusing there: they act on a name the user can't see, and opening the tab rename editor spills it across the pane rows.
This PR suppresses tab-name actions for a grouped tab in Panes view:
• Adds
TabData::tab_name_hidden_in_grouped_pane_view(ctx)— true when the tab is in a group, vertical tabs are on, and the display granularity is Panes.• Hides the "Rename tab" and "Reset tab name" entries from the tab context menu in that case (pane rename/reset entries remain).
• Makes the
RenameActiveTabaction (keyboard shortcut / command) a no-op in that case instead of opening the editor.Linked Issue
https://linear.app/warpdotdev/issue/APP-4810/hide-rename-tab-option-for-tab-in-group-for-pane-view
Testing
./script/runScreenshots / Videos
Demo video