Update Git Operations AI client billing policy#9840
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR wires the new Git Operations AI billing policy through the GraphQL schema/model layer and uses it to gate the Git dialog AI request path plus the corresponding AI settings toggle.
Concerns
- Adding a required serde field to
WarpAiPolicycan make existing cachedbilling_metadata_jsonrows fail to deserialize, causing the app to drop cached billing metadata until a successful refresh. - No security-specific findings.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| pub is_code_suggestions_toggleable: bool, | ||
| pub is_prompt_suggestions_toggleable: bool, | ||
| pub is_next_command_enabled: bool, | ||
| pub is_git_operations_ai_enabled: bool, |
There was a problem hiding this comment.
billing_metadata_json cache rows can contain warp_ai_policy without this new field; without a serde default, deserializing the cached BillingMetadata fails and drops all cached billing policy data until refresh.
| pub is_git_operations_ai_enabled: bool, | |
| #[serde(default)] | |
| pub is_git_operations_ai_enabled: bool, |
Co-Authored-By: Oz <oz-agent@warp.dev>
Description
Adds the client-side follow-up for the Git Operations AI enterprise/tier policy:
isGitOperationsAiEnabledto the client GraphQL schema andWarpAiPolicyfragments/models.This is intended to pair with the server-side schema/policy change in warpdotdev/warp-server#10798. Keeping this PR as draft until the server field is available to clients.
Linked Issue
N/A — client follow-up for the server GraphQL schema/policy PR.
Screenshots / Videos
N/A — this is policy/schema wiring. The existing setting is hidden when the new billing policy disables Git Operations AI.
Testing
cargo fmt --manifest-path /Users/edward/Repos/edward-update-git-ops-ai-schema/Cargo.toml --all -- --checkcargo clippy --manifest-path /Users/edward/Repos/edward-update-git-ops-ai-schema/Cargo.toml -p warp_graphql_schema -p warp_graphql -p warp --all-targets --all-features --tests -- -D warningsgit --no-pager diff --checkNo new integration test added; this is a small billing-policy plumbing change that reuses existing settings/request gates.
Agent Mode
Agent conversation: https://staging.warp.dev/conversation/281d784d-6c87-414f-89db-1b29f771f571
Co-Authored-By: Oz oz-agent@warp.dev