[fix] #3105: Input stops working after clicking 'Warpify subshell' in poetry/pipenv

[mitre88]

Problem

When users launch a subshell using poetry shell or pipenv shell and click "Warpify subshell", all keyboard input stops working. Users cannot type commands, use Ctrl+C, or Ctrl+D to exit.

Root Cause

pexpect (used by poetry and pipenv to spawn subshells) manages its own PTY state. When Warp sends Ctrl-U and Ctrl-K control characters to clear the line before sending the InitShell DCS hook, these characters interfere with pexpect's PTY management, causing input to be blocked.

Solution

1. Added is_pexpect_subshell() helper method that detects if the current subshell is poetry or pipenv by checking the spawning_command against the existing POETRY_SUBSHELL_COMMAND_REGEX and PIPENV_SUBSHELL_COMMAND_REGEX.

2. Added write_init_subshell_bytes_to_pty_without_clearing() method that writes the InitShell DCS hook directly without sending Ctrl-U/Ctrl-K first.

3. Modified trigger_subshell_bootstrap() to check if the subshell is pexpect-based and use the non-clearing variant in that case.

This approach is consistent with the existing code which already uses RC-file based bootstrap for poetry/pipenv subshells during initial session bootstrapping (see should_use_rc_file_bootstrap_method in bootstrap.rs).

Testing

• Code compiles and passes clippy
• Follows existing code patterns
• Specific error handling (no bare except clauses)

Fixes #3105

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dr. Alex Mitre.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[oz-for-oss]

@mitre88

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR attempts to fix Poetry/Pipenv subshell warpification by skipping the Ctrl-U/Ctrl-K line-clearing bytes before sending the InitShell DCS hook for pexpect-backed subshells.

Concerns

• The new pexpect detection reads session.subshell_info() from the currently bootstrapped session, not from the command currently being warpified. For the reported flow, the active session is still the parent session before the Poetry/Pipenv subshell bootstraps, so this usually returns None and the code still sends Ctrl-U/Ctrl-K.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

⚠️ [IMPORTANT] This checks the already bootstrapped parent session, so subshell_info() is usually None before the poetry shell/pipenv shell subshell is initialized; the reported flow still falls back to sending Ctrl-U/Ctrl-K. Base this on the active block/banner command being warpified instead.