Standardize drag & drop behavior between Project Explorer and Finder (APP-4360)#9874
Draft
warp-dev-github-integration[bot] wants to merge 1 commit intomasterfrom
Draft
Standardize drag & drop behavior between Project Explorer and Finder (APP-4360)#9874warp-dev-github-integration[bot] wants to merge 1 commit intomasterfrom
warp-dev-github-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Fixes the inconsistency where files dragged from the Project Explorer were handled differently than files dragged from Finder: - Project Explorer → Input: was inserting relative path without shell escaping or image detection. Now routes through the editor's DragAndDropFiles action (same as Finder), so image files are detected and attached as context, non-image paths are shell-escaped and transformed for WSL, and absolute paths are used consistently. - Project Explorer → Terminal (long-running command): was inserting the absolute path directly without shell escaping or image detection. Now routes through TerminalView::drag_and_drop_files (same as Finder), so shell escaping, WSL path conversion, and SSH file upload all apply. Resolves APP-4360 Co-Authored-By: Oz <oz-agent@warp.dev>
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: {"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/users/users#get-the-authenticated-user","status":"403"}.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardizes drag & drop behavior so that files dropped from the Project Explorer are handled identically to files dropped from Finder (the OS-level drag source).
Before:
After:
Both Project Explorer and Finder drops now go through the same code paths:
ItemDroppedOnInputroutes through the editor'sDragAndDropFilesaction, which handles image detection/attachment, shell escaping, WSL path transformation, and uses absolute pathsItemDroppedOnTerminalroutes throughTerminalView::drag_and_drop_files, which handles image detection, shell escaping, WSL path conversion, MSYS2 handling, and SSH file uploadLinked Issue
Resolves APP-4360
ready-to-specorready-to-implement.Testing
cargo check -p warpcargo fmtAgent Mode
Conversation: https://staging.warp.dev/conversation/05a569bf-0326-4e06-bef5-45d5e69eb591
Run: https://oz.staging.warp.dev/runs/019de638-7042-7076-a220-3c58e8b1bd2d
This PR was generated with Oz.