Merged
Conversation
lachieh
force-pushed
the
example/hono-adapter
branch
2 times, most recently
from
381139b to
4f1c793
Compare
rajsite
reviewed
Apr 30, 2025
Contributor
|
Hey @lachieh that's true, but it isn't until Also another nice thing is that eventually theoretically Hono should support this naturaly (when they have WinterTC support) so this can maybe completely disappear. |
lachieh
force-pushed
the
example/hono-adapter
branch
2 times, most recently
from
a91b21b to
cf3147c
Compare
vados-cosmonic
approved these changes
May 7, 2025
Contributor
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Ignore my comment on componentize-js that's currently bundled with jco not working -- it is working as evidenced by your test.
…gMonkey takes care of it Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
lachieh
force-pushed
the
example/hono-adapter
branch
from
cf3147c to
5d6bb77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with the StarlingMonkey team, they pointed out that my transforms from the
wasi:http/'sIncomingRequesttype fo the standardRequesttype were unnecessary since the runtime can handle this with an event listener on the'fetch'event. I've removed the unneccesary code and updated the README.