chore(deps): update actions/checkout action to v7 - #16
Conversation
|
PR author is in the excluded authors list. |
|
🌊 WAVE BugBot — 7 finding(s)🔴 6 · 🟠 1
severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune |
591ee58 to
eb88e93
Compare
eb88e93 to
28390c8
Compare
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🔍 Checkout step here still lacks persist-credentials: false unlike all others
Every other checkout in the repo (.github/workflows/_checks.yml:23, :54, :114 and .github/workflows/python-lint.yml:23-25) sets with: persist-credentials: false, but this guard job leaves the default. Note actions/checkout v7 still persists credentials by default, so the inconsistency remains after the bump; worth aligning while touching the line.
Was this helpful? React with 👍 or 👎 to provide feedback.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🟨 Checkout step in the public-repo-guard workflow leaves credentials on disk
The checkout step in .github/workflows/public-repo-guard.yml:45 is the only one in the repo without persist-credentials: false (compare .github/workflows/_checks.yml:24-25 and .github/workflows/python-lint.yml:24-25). The workflow subsequently downloads and executes a third-party binary (gitleaks) and runs a repo-vendored shell script over PR-controlled content, all while the GITHUB_TOKEN remains written into .git/config, making token theft possible if any of that step's inputs are compromised.
Was this helpful? React with 👍 or 👎 to provide feedback.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a CI-only checkout dependency bump with no SDK runtime or schema changes, but it affects release and public-repository security workflows. An unresolved concrete concern about retaining GITHUB_TOKEN credentials in the security guard, together with all changed files being owned by the core team, warrants human review. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
28390c8 to
8351e4b
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
8351e4b to
c36abac
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
c36abac to
420f290
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
420f290 to
a20ff4a
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
a20ff4a to
c816ff4
Compare
|
Skipping PR review because a bot author is detected. If you want to trigger CodeAnt AI, comment |
c816ff4 to
35ce281
Compare
35ce281 to
29411ca
Compare
This PR contains the following updates:
v6.0.3→v7.0.1v5.0.1→v7.0.1v4.3.1→v7.0.1Release Notes
actions/checkout (actions/checkout)
v7.0.1Compare Source
v7.0.0Compare Source
v6.1.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.