docs: how to take a booking-grid change safely - #45
Merged
Conversation
The half-hour move is the first release where adopting the package in the wrong order breaks live calls, and the constraint lives in the platform's docs — where a consumer of this package will never look. Release-As: 0.0.11
The device half of the same note: this crate is what computes the required set, so it has to move first. Release-As: 0.0.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two READMEs, and the version override that goes with them.
feat(book)!marked the grid change breaking, which under this repo'sbump-minor-pre-majorconfig sends both packages to0.1.0. Pre-1.0that's a signal we don't need: every
0.0.xis already an incompatiblerange to both cargo and npm, so consumers must bump explicitly either
way, and the minor buys nothing but a burned version.
So each commit carries a
Release-As:footer —0.0.11for the npmpackage,
0.0.8for the crate — and release-please will rewrite #44 tothose. Rebase-merge, not squash: the footers are per-package and
release-please attributes them by the paths each commit touches.
What the commits actually add is the note that was missing. The ordering
constraint that makes a grid change dangerous — devices compute
required_assetsfrom their own compiled-in constant, so they must movebefore the authoring side — was written down only in the platform's
private docs, which nobody installing either package can read.
🤖 Generated with Claude Code
https://claude.ai/code/session_018stjkZJ4kxDViq1ENnVDmH