fix: Windows path resolution for session state file#2
Open
hhwjsw711 wants to merge 1 commit intowaynesutton:mainfrom
Open
fix: Windows path resolution for session state file#2hhwjsw711 wants to merge 1 commit intowaynesutton:mainfrom
hhwjsw711 wants to merge 1 commit intowaynesutton:mainfrom
Conversation
…bility On Windows, process.env.HOME is undefined, causing the plugin to create a literal '~' directory in the project folder instead of using the user's home directory. This commit replaces all occurrences of 'process.env.HOME || "~"' with 'os.homedir()' for proper cross-platform path resolution. Changes: - Added 'import * as os from "os"' to src/cli.ts - Fixed 3 path.join() calls to use os.homedir() - setup command (line 469) - verify command (line 547) - SESSION_STATE_FILE constant (line 652) Fixes Windows path issue where session state file was created in project directory instead of user home directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, the plugin incorrectly creates a
~directory in the project folder instead of using the user's home directory. This is becauseprocess.env.HOMEis undefined on Windows.Solution
Replace
process.env.HOME || "~"withos.homedir()for cross-platform compatibility.Changes
import * as os from "os"tosrc/cli.tsprocess.env.HOME || "~"withos.homedir()Testing
C:\Users\<username>\.config\claude-code-sync\)~folder in project directoriessrc/index.ts:331Related Issue
Fixes the Windows path issue where session state file was created in project directory instead of user home directory.