Conversation
amourao
commented
Apr 20, 2026
- Update in and out format to match latest server changes
…urations and improve response handling
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
There was a problem hiding this comment.
Pull request overview
Updates the client’s tokenization request/response shapes to align with recent server changes for /v1/tokenize, including stopwords handling and the minimal response format.
Changes:
- Simplifies
TokenizeResultto match the generic endpoint’s minimal response (indexed/query only) and makestokenizationoptional (property endpoint only). - Updates tokenization executor input shape: adds
stopwords, changesstopword_presetstoDict[str, List[str]], and enforces the server’s mutual-exclusion rule client-side. - Adjusts integration tests and CI Weaviate version pin to reflect the updated behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
weaviate/tokenization/models.py |
Aligns TokenizeResult fields with new server response shape and makes tokenization optional. |
weaviate/tokenization/executor.py |
Updates request payload schema for stopwords/presets and adds client-side mutex validation. |
integration/test_tokenize.py |
Updates expected outputs and adds coverage for default stopword behavior and mutex validation. |
.github/workflows/main.yaml |
Pins the 1.37.1 CI Weaviate version to a specific build suffix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…n-client into fix/tokenize_simple_output
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.37 #2019 +/- ##
============================================
+ Coverage 86.69% 86.72% +0.02%
============================================
Files 296 297 +1
Lines 22862 22826 -36
============================================
- Hits 19821 19795 -26
+ Misses 3041 3031 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ved readability and maintainability
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tsmith023
left a comment
There was a problem hiding this comment.
For collection.config.tokenize_property, wdyt about moving it to collection.tokenize.property to align the namespaces between the client and collection objects?