feat(core): update special case for planning prompt#1904
feat(core): update special case for planning prompt#1904yuyutaotao wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2db4028e6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| **Special case - Conditional instructions:** | ||
| - If the user's instruction is conditional (e.g., "if ... then ...", "if there is a ... click ...", "when ... do ..."), and the condition is NOT satisfied (e.g., the element doesn't exist), this is NOT an error. Mark the goal as accomplished (success="true") and explain that the condition was not met so no action was taken. | ||
| - Example: "If there is a cookie consent prompt, click Accept" - if no cookie prompt exists, return <complete-goal success="true">No cookie consent prompt found on the page, no action needed</complete-goal> |
There was a problem hiding this comment.
This rule unconditionally treats any conditional instruction as a full-goal completion when the condition is unmet. That breaks cases where the user mixes a conditional with additional required steps (e.g., “If there is a cookie prompt, click Accept, then sign in”). If the cookie prompt is absent, this guidance tells the model to emit <complete-goal success="true"> and stop, so the sign-in never happens even though it’s still required. This can lead to false successes whenever the instruction contains a conditional clause but isn’t solely conditional.
Useful? React with 👍 / 👎.
Deploying midscene with
|
| Latest commit: |
2db4028
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34f11d2e.midscene.pages.dev |
| Branch Preview URL: | https://feat-special-case-for-planni.midscene.pages.dev |
1 participant
No description provided.