Repository navigation
docs: add a screenshot banner to the README - #6
Merged
Merged
Conversation
- docs/images/webarkit-studio.webp: the multi NFT demo in the studio, 4:3 (1600x1200), with the live preview tracking pinball and kuva. - Re-layout the demo graphs: Controller Settings grew with near / far and overlapped One Euro Filter; nodes are now spaced by their size. - .gitattributes: add the missing final newline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeYTpqS6Pp22dNxwQ1gjWF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a screenshot banner to the README, and fixes the demo graph layouts that the screenshot exposed.
Banner
docs/images/webarkit-studio.webp: the multi NFT demo open in the studio, with the live preview tracking both markers (pinball → torus knot, kuva → box).Demo graph layout
Since near / far were added, Controller Settings is taller and overlapped One Euro Filter. The two Light nodes also overlapped Scene. All three demos (
pinball-three,pinball-babylon,multi-three) are now laid out on four columns, spaced by the real node heights measured while tracking (Inspector and Stats grow at runtime).Only
position.x/position.ychange; nodes, params and edges are untouched, so there is no graph format change.Other
.gitattributes: add the missing final newline.CHANGELOG.md: "Fixed" entry for the overlapping demo nodes.Test plan
npm run typechecknpm test: 44 passednpm run test:e2e: 11 passed. In one run "an init error is shown on the failing node" failed once; with--repeat-each 5it passed every time, so it looks flaky rather than caused by the layout change.🤖 Generated with Claude Code
https://claude.ai/code/session_01LeYTpqS6Pp22dNxwQ1gjWF