Repository navigation
Update to support revamped proposal #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+15,178
−24,189
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
5658304
Update to sport revamped proposal in https://github.com/whatwg/html/i…
3813889
handle connection and add more tests
974ce1a
update to latest proposed spec
dba8e99
Merge branch 'master' into revamped
2332065
amended changelog
c8c5724
update package-lock
0dd39fa
update to current spec property `customElementRegistry`
6debe16
Update changelog
f4f20f4
Update packages/scoped-custom-element-registry/src/types.d.ts
sorvell a115843
Update packages/scoped-custom-element-registry/src/types.d.ts
sorvell 057092f
Update packages/scoped-custom-element-registry/src/types.d.ts
sorvell 9995a9e
Update packages/scoped-custom-element-registry/src/types.d.ts
sorvell 436c5a7
Add comments with spec links
d2a52ce
Update packages/scoped-custom-element-registry/src/types.d.ts
sorvell 6671d59
Address feedback: remove unneeded fallback
41b0496
Change to an actual polyfill
e5eb55a
sync with spec and improve compatibility with partial platform support
52a5abb
Merge branch 'master' into revamped
0ac54ee
Update browsers before testing
db15dc9
format
9a3a1c0
update node
90fdc22
update node again
7d9952e
install deps for Firefox.
8da9f35
updating deps again
31cb234
update playwright to get firefox installed
ff4c0e7
claude assisted test config updates.
3268dff
install playwright within packages where needed
57ead23
update deps
bbacceb
ensure a recent ubuntu to get most recent browsers
f386038
revert version change
585d6fa
temporary test logging
8f5406c
logging try2
40b276b
isolate failure
49591b7
more test debugging
681c07a
debugging: add first dsd
6fd6963
debugging: define early
3eaf560
debugging: add first test
609a4ab
debugging: only without native null
7db7ff7
add force option and use in DSD testing
7daedee
update node, remove sauce.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,10 @@ jobs: | |
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16 | ||
| node-version: 24.5 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why not just |
||
|
|
||
| - name: NPM install | ||
| run: npm ci | ||
|
|
@@ -25,47 +25,24 @@ jobs: | |
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16 | ||
| node-version: 24.5 | ||
|
|
||
| - name: NPM install | ||
| run: npm ci | ||
|
|
||
| - name: Lerna bootstrap | ||
| run: npm run bootstrap | ||
|
|
||
| - name: Build | ||
| run: npm run build | ||
|
|
||
| - name: Test | ||
| run: npm test | ||
|
|
||
| sauce: | ||
| # Skip if this is from a forked repository because we can't access Sauce | ||
| # secrets. | ||
| if: github.event.pull_request.base.repo.id == github.event.pull_request.head.repo.id | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
|
|
||
| - name: NPM install | ||
| run: npm ci | ||
|
|
||
| - name: Lerna bootstrap | ||
| run: npm run bootstrap | ||
| - name: Install playwright browsers (+ deps) | ||
| run: | | ||
| cd packages/tests && npx playwright install --with-deps | ||
| cd $GITHUB_WORKSPACE/packages/scoped-custom-element-registry && npx playwright install --with-deps | ||
|
|
||
| - name: Build | ||
| run: npm run build | ||
|
|
||
| - name: Test | ||
| env: | ||
| SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }} | ||
| SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }} | ||
| run: npm run test-sauce | ||
| run: npm test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both
checkoutandsetup-nodeare at version 6 atmThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v7, actually