ci: give each edgedriver e2e test its own driver cache dir - #14
Merged
dprevost-LMI merged 2 commits intoSep 21, 2026
Merged
Conversation
Tests previously shared one cache path (EDGEDRIVER_CACHE_DIR or os.tmpdir()) and deleted+redownloaded into it between tests, racing against whatever process the prior test hadn't fully torn down. Each test now gets a fresh mkdtemp() dir instead, removing the shared-file race entirely. Also drops the EDGE_BINARY_PATH cleanup block, which was dead code: that env var locates the Edge browser binary (see finder.ts), not a driver cache path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dprevost-LMI
force-pushed
the
fix/edgedriver-e2e-oom
branch
from
September 21, 2026 12:35
f18bdb1 to
beea65a
Compare
dprevost-LMI
enabled auto-merge (squash)
September 21, 2026 12:35
afterEach only deleted the per-test cache dir; it never confirmed the driver process was dead first. On Windows that's a hard EPERM (can't unlink a running .exe); on Linux/macOS it silently "succeeds" while the process keeps running and consuming memory - the same mechanism likely behind the original Ubuntu OOM. Kill is now cross-platform (taskkill on Windows, pkill elsewhere), runs in afterEach too (not just beforeEach), and fs.rm gets retries since Windows can lag briefly releasing the file handle even after the process exits. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests previously shared one cache path (EDGEDRIVER_CACHE_DIR or os.tmpdir()) and deleted+redownloaded into it between tests, racing against whatever process the prior test hadn't fully torn down. Each test now gets a fresh mkdtemp() dir instead, removing the shared-file race entirely. Also drops the EDGE_BINARY_PATH cleanup block, which was dead code: that env var locates the Edge browser binary (see finder.ts), not a driver cache path.