Open
Conversation
cliebhardt
added
the
status: waiting-for-review
cliebhardt
requested review from
EHandtkeBasis,
MatthewHawkins,
bbrennanbasis,
gosteenBASIS and
laurenic0l
as code owners
hyyan
requested changes
Jan 29, 2026
src/main/kotlin/com/webforj/samples/views/button/ButtonDisableKotlinView.kt
Outdated
Show resolved
Hide resolved
hyyan
added
status: waiting-for-author
hyyan
requested changes
Feb 3, 2026
src/main/kotlin/com/webforj/samples/views/button/ButtonIconKotlinView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/webforj/samples/views/button/ButtonThemesKotlinView.kt
Outdated
Show resolved
Hide resolved
cliebhardt
added
status: waiting-for-review
laurenic0l
requested changes
Feb 4, 2026
Contributor
laurenic0l
left a comment
laurenic0l
left a comment
There was a problem hiding this comment.
a few minor tweaks, but it looks good!
src/main/kotlin/com/webforj/samples/views/button/ButtonEventKotlinView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/webforj/samples/views/button/ButtonThemesKotlinView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/webforj/samples/views/button/ButtonExpansesKotlinView.kt
Outdated
Show resolved
Hide resolved
hyyan
added
status: waiting-for-author
hyyan
requested changes
Feb 6, 2026
Member
hyyan
left a comment
hyyan
left a comment
There was a problem hiding this comment.
Please also fix the Java demos while you’re working on this. Update them to use the discussed pattern where self = boundComponent.
cliebhardt
force-pushed
the
kotlin/button-views
branch
from
3cb59d0 to
663df3e
Compare
cliebhardt
force-pushed
the
kotlin/integration
branch
from
1dbf01d to
ba0dc6b
Compare
- removed unused import in ButtonExpansesKotlinView - fixed imports for prefix and suffix in ButtonIconKotlinView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.