Fixed the ability to sort columns that use integers.#196
Open
macornwell wants to merge 1 commit intowebismymind:masterfrom
Open
Fixed the ability to sort columns that use integers.#196macornwell wants to merge 1 commit intowebismymind:masterfrom
macornwell wants to merge 1 commit intowebismymind:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a bug that exists if you attempt to sort columns that have integers values. Currently sorting columns with integers results in an exception referencing ".toLowerCase".
This code change determines if the values are ints, and if not, uses the current code, otherwise sorts by integer value.