Paginated list by rakeshM-Webonise · Pull Request #2 · webonise/react-native-poc

rakeshM-Webonise · 2019-05-15T12:51:11Z

No description provided.

…tive-poc into paginated-list

vjnathe-webonise · 2019-05-21T05:51:17Z

+import variable from './../variables/platform';
+
+export default (variables /*: * */ = variable) => {
+  const bodyTheme = {


directly return from here, no need to create variable.

Above code is in Native base theme third party Library.

vjnathe-webonise · 2019-05-21T05:55:28Z

@@ -0,0 +1,90 @@
+// @flow


we can use file naming conventions for such fil as Form.style.js and for component Form.js

Above code is in Native base theme third party Library.

vjnathe-webonise · 2019-05-21T06:03:00Z

@@ -0,0 +1,25 @@
+var localDB ={


should be export localDB

vjnathe-webonise · 2019-05-21T06:04:02Z

+              </Text>
+            </View>
+            <View style={styles.menuItem}>
+              <Image source={{uri:'https://img.icons8.com/ios/60/000000/google-nearby.png'}}/>


uri should be constant

Changes has been done as per suggestions.

vjnathe-webonise · 2019-05-21T06:07:02Z

+
+export default DrawerScreen;
+
+const styles = StyleSheet.create({


we can move this to separate file DrawerScreen.style.js and export from there.
I recommend to create directory with name DrawerScreen under that all the files related to that will exist.
eg. DrawerScreen.jsx(component), DrawerScreen.test.js(test cases) & DrawerScreen.style.js(stylesheets)

vjnathe-webonise · 2019-05-21T06:07:31Z

@@ -0,0 +1,116 @@
+import React from "react";
+import { FlatList, StyleSheet, Text, View, Image } from "react-native";
+import { Button } from "react-native-elements";


combine 2 imports

vjnathe-webonise · 2019-05-21T06:10:58Z

+  };
+
+  componentWillMount() {
+    this.getUserInfo(0);


this should be in componentDidMount, componentWillMount is deprecated in higher version of react. and we should pass this.state.page to method getUserInfo as its initial value is 0

vjnathe-webonise · 2019-05-21T06:11:53Z

+  getUserInfo(page) {
+    console.log("getting user info fior page " + page);
+
+    const URL = `https://reqres.in/api/users/?page=${page}`;


should be: const URL = https://reqres.in/api/users/?page=${this.state.page};

vjnathe-webonise · 2019-05-21T06:13:11Z

+  );
+
+  gotoNextPage = () => {
+    this.getUserInfo(this.state.page + 1);


should be:

this.setState({ page: this.state.page < this.state.total_pages ? this.state.page + 1 : this.state.page, }, this.getUserInfo);

vjnathe-webonise · 2019-05-21T06:14:03Z

+  };
+
+  gotoPreviousPage = () => {
+    this.getUserInfo(this.state.page - 1);


should be:

this.setState({ page: this.state.page > 1 ? this.state.page - 1 : this.state.page, }, this.getUserInfo);

We are not using Gridscreen.js. So file has been deleted

vjnathe-webonise · 2019-05-21T06:15:24Z

+    this.getUserInfo(0);
+  }
+
+  getUserInfo(page) {


no need to pass page as parameter as we can refer it as state variable

We are not using Gridscreen.js. So file has been deleted

vjnathe-webonise · 2019-05-21T06:17:31Z

@@ -1,188 +1,676 @@
-import React from 'react';
+/*import React from "react";


clean the commented code

Changes has been done as per suggestions.

vjnathe-webonise · 2019-05-21T06:18:56Z

-      </View>
-    );
+
+  mapStyle = [


move to constants or config file

vjnathe-webonise · 2019-05-21T06:19:20Z

+    }
+  ];
+  componentDidMount() {
+    Geocoder.init("AIzaSyD7JZmztK5wE-80P8t-_IOHZQinVtx4Dio");


token should be from config

vjnathe-webonise · 2019-05-21T06:20:28Z

+    ScreenOrientation.allowAsync(ScreenOrientation.Orientation.ALL);
+    if (Platform.OS === "android" && !Constants.isDevice) {
+      console.log("Permission denied");
+      this.setState({


we can not do setState on component which is not mounted yet, use componentDidMount instead

vjnathe-webonise · 2019-05-21T06:21:51Z

+  } 
 }

 const styles = StyleSheet.create({


move to component style file

vjnathe-webonise · 2019-05-21T06:24:42Z

+    }
+  };
+
+  mapStyle = [


move to separate constant or config file

vjnathe-webonise · 2019-05-21T06:25:50Z

+    console.log("getLatsstLongs called "+locationName);
+    Geocoder.from(locationName)
+          .then(json => {
+              var location = json.results[0].geometry.location;


use try/catch for better error handling, what if json.results is undefined OR json.results having length 0

vjnathe-webonise · 2019-05-21T06:26:45Z

+    });
+  }
+
+  componentWillMount() {


use componentDidMount, we can not do setState before component mount

Changes has been done as per suggestions.

vjnathe-webonise · 2019-05-21T06:27:34Z

+  }
+
+
+  _getLocationAsync = async () => {


repetitive code, we can create utility async function for this

vjnathe-webonise · 2019-05-21T06:29:48Z

+export default  class UserInfoDBManager extends Component {
+
+  constructor() {
+       this.sqlite = SQLite;


fix indentation

UserInfoDBManager.js file has been deleted.No used in App

vjnathe-webonise · 2019-05-21T06:30:04Z

+           location: "1"
+       }).then((db) => {
+           this.dbInstance = db;
+       })


error case not handled ?

vjnathe-webonise · 2019-05-21T06:30:50Z

+
+   createTable() {
+     return new Promise((resolve, reject) => {
+            this.dbInstance.executeSql('CREATE TABLE IF NOT EXISTS ' + localDB.tableName.tblLogin + ' (id  INTEGER PRIMARY KEY ,firstName TEXT,lastName TEXT,avator:TEXT)'


what is this.dbInstance is undefined ? this is the case where DB connection failed.

vjnathe-webonise · 2019-05-21T06:32:19Z

+           this.dbInstance.executeSql(
+               "DELETE FROM"+ localDB.tableName.tblLogin
+           ).then((val) => {
+               resolve(true);


no need to return true/false explicitly, you can tread resolve callback for positive flow and reject callback for error flow

…dded, 4.Gallary functionality added

- Code segregation - code optimized

ameyawebonise and others added 30 commits March 11, 2019 21:23

Added the different content on the home screen

db57c1d

Clobbered up a basic api call

4f50b8c

Added the grid

f19103e

Changes for adding a new screen

d9e7d03

Added basic navigation features

52523fd

Added the proper navigation

3784e32

Added basic navigation

d77ed8a

Formatter code

60bcc4b

Changes the name

9a1c777

changes for adding the grid

9435e51

Changes for adding the maps

11d8f63

Changes for adding the marker

f75fc50

Removed the hard coding

ed89d98

added the pagniated list

e246883

Chagnes

fa3d45d

Added the placeholder

ccd461f

Added the page loader

2324f43

pagination implemented

f83cd43

modified the flatlist

33bf8ac

modified the flatlist

5908a2f

modified the flatlist

9c4ce73

modified the flatlist

7fa23c5

increase the padding for list to scrool

6569a1d

removing the orientation constarint

8e79422

removing the orientation constarint

76249b7

removing white spaces

b9a9ce6

removed conflicts

ae63f05

Merge branch 'paginated-list' of https://github.com/webonise/react-na…

9df1b6b

…tive-poc into paginated-list

Commented code conflicts removed.

7f18c32

Permissions for locations added

a4c7c1b

vjnathe-webonise reviewed May 21, 2019

View reviewed changes

rakeshM-Webonise added 6 commits May 21, 2019 18:21

didScrollEnd Pagination bug fixed

caacdc8

Alert Permission fixed andorid

24265c3

1.AsynchStorage added, 2.Secure Store added ,3.Camera functionality a…

0be1fe5

…dded, 4.Gallary functionality added

seprate Images added for Local and Secure storage

6f75b35

Code review suggestion are fixed

28ae75e

- Code segregation - code optimized

Pull request issues fixed

ecbffd1


		export default DrawerScreen;

		const styles = StyleSheet.create({

		@@ -1,188 +1,676 @@
		import React from 'react';
		/*import React from "react";

Conversation

rakeshM-Webonise commented May 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vjnathe-webonise May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vjnathe-webonise May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vjnathe-webonise May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

vjnathe-webonise May 21, 2019 •

edited

Loading

vjnathe-webonise May 21, 2019 •

edited

Loading

vjnathe-webonise May 21, 2019 •

edited

Loading