Skip to content

fix(generation): fix class jsdoc generation#39

Merged
avivkeller merged 1 commit into
mainfrom
fix-class-docs
May 23, 2026
Merged

fix(generation): fix class jsdoc generation#39
avivkeller merged 1 commit into
mainfrom
fix-class-docs

Conversation

@avivkeller
Copy link
Copy Markdown
Member

Fixes #37

Copilot AI review requested due to automatic review settings May 22, 2026 22:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes missing JSDoc emission for generated declare class blocks in the generate-types tool (Issue #37), so class-level documentation is preserved in the resulting types.d.ts.

Changes:

  • Extend the internal MergedClassType shape to carry documentation.
  • Propagate documentation when converting/merging interface shapes into class shapes.
  • Prefix generated class declarations with the captured documentation (matching existing interface behavior).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller merged commit 7072976 into main May 23, 2026
8 checks passed
@avivkeller avivkeller deleted the fix-class-docs branch May 23, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate-types does not include all JSDoc

3 participants