Skip to content

chore: remove unused code #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 1 commit into from
May 22, 2025
Merged

chore: remove unused code #4463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/webpack-cli/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ interface IWebpackCLI {
toKebabCase: StringFormatter;
capitalizeFirstLetter: StringFormatter;
checkPackageExists(packageName: string): boolean;
getAvailablePackageManagers(): PackageManager[];
getDefaultPackageManager(): PackageManager | undefined;
doInstall(packageName: string, options?: PackageInstallOptions): Promise<string>;
loadJSONFile<T = unknown>(path: Path, handleError: boolean): Promise<T>;
Expand Down
28 changes: 2 additions & 26 deletions packages/webpack-cli/src/webpack-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,33 +184,7 @@ class WebpackCLI implements IWebpackCLI {
return false;
}

getAvailablePackageManagers(): PackageManager[] {
const { sync } = require("cross-spawn");
const installers: PackageManager[] = ["npm", "yarn", "pnpm"];
const hasPackageManagerInstalled = (packageManager: PackageManager) => {
try {
sync(packageManager, ["--version"]);

return packageManager;
} catch (_err) {
return false;
}
};
const availableInstallers = installers.filter((installer) =>
hasPackageManagerInstalled(installer),
);

if (!availableInstallers.length) {
this.logger.error("No package manager found.");

process.exit(2);
}

return availableInstallers;
}

getDefaultPackageManager(): PackageManager | undefined {
const { sync } = require("cross-spawn");
const hasLocalNpm = fs.existsSync(path.resolve(process.cwd(), "package-lock.json"));

if (hasLocalNpm) {
Expand All @@ -229,6 +203,8 @@ class WebpackCLI implements IWebpackCLI {
return "pnpm";
}

const { sync } = require("cross-spawn");

try {
// the sync function below will fail if npm is not installed,
// an error will be thrown
Expand Down