Skip to content

refactor: use optional chaining & delete unnecessary assertion#4465

Merged
alexander-akait merged 1 commit intowebpack:masterfrom
noritaka1166:refactor-code
May 23, 2025
Merged

refactor: use optional chaining & delete unnecessary assertion#4465
alexander-akait merged 1 commit intowebpack:masterfrom
noritaka1166:refactor-code

Conversation

@noritaka1166
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
no

If relevant, did you update the documentation?
no

Summary
use optional chaining & delete unnecessary assertion

Does this PR introduce a breaking change?
no

Other information
no

@noritaka1166 noritaka1166 requested a review from a team as a code owner May 23, 2025 08:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (31f634a) to head (79a8c65).
Report is 239 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4465      +/-   ##
==========================================
- Coverage   90.18%   89.94%   -0.25%     
==========================================
  Files          22        9      -13     
  Lines        1702     1412     -290     
  Branches      491      461      -30     
==========================================
- Hits         1535     1270     -265     
+ Misses        167      142      -25     
Files with missing lines Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 91.04% <100.00%> (-1.60%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd435ab...79a8c65. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait alexander-akait merged commit 9a2f306 into webpack:master May 23, 2025
54 of 55 checks passed
@alexander-akait
Copy link
Copy Markdown
Member

Thanks

@noritaka1166 noritaka1166 deleted the refactor-code branch May 23, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants