Skip to content

refactor: change if in else to else if#4470

Merged
alexander-akait merged 1 commit intowebpack:masterfrom
noritaka1166:refactor-else
Jun 5, 2025
Merged

refactor: change if in else to else if#4470
alexander-akait merged 1 commit intowebpack:masterfrom
noritaka1166:refactor-else

Conversation

@noritaka1166
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
no

If relevant, did you update the documentation?
no

Summary
change if in else to else if for better readability

Does this PR introduce a breaking change?
no

Other information

@noritaka1166 noritaka1166 requested a review from a team as a code owner May 31, 2025 15:33
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (31f634a) to head (97a0bc3).
Report is 245 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
- Coverage   90.18%   89.93%   -0.26%     
==========================================
  Files          22        9      -13     
  Lines        1702     1411     -291     
  Branches      491      460      -31     
==========================================
- Hits         1535     1269     -266     
+ Misses        167      142      -25     
Files with missing lines Coverage Δ
packages/configtest/src/index.ts 93.10% <100.00%> (-3.33%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5295c5f...97a0bc3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could shorten this statement more, but for now lgtm

@alexander-akait alexander-akait merged commit 8ed5f3d into webpack:master Jun 5, 2025
54 of 55 checks passed
@noritaka1166 noritaka1166 deleted the refactor-else branch June 5, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants