fix(pgsql): embed RawExpression in UPDATE without placeholder#50
Merged
Conversation
PostgresGrammar::compileUpdate() was mapping over array_keys() and always emitting `col = ?`, ignoring RawExpression values used by increment() and decrement(). This caused a binding count mismatch on PostgreSQL. Mirror the logic from Grammar::compileUpdate(): iterate over values, embed RawExpression directly, emit ? only for scalar values. Adds two regression tests in GrammarTest: - test_pgsql_update_embeds_raw_expression_without_placeholder - test_pgsql_update_mixes_raw_and_normal_values Fixes #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgresGrammar::compileUpdate() was mapping over array_keys() and always emitting
col = ?, ignoring RawExpression values used by increment() and decrement(). This caused a binding count mismatch on PostgreSQL.Mirror the logic from Grammar::compileUpdate(): iterate over values, embed RawExpression directly, emit ? only for scalar values.
Adds two regression tests in GrammarTest:
Fixes #49