Skip to content

Fix 50 followups - #298

Merged
queil merged 2 commits into
mainfrom
fix-50-followups
Sep 24, 2026
Merged

queil merged 2 commits into
mainfrom
fix-50-followups

Conversation

@queil

@queil queil commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@strix-security

strix-security Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Strix Security Review

No security issues found.

Review summary

Reviewed all three changed files. The substantive change is in src/Weir/Proc.fs, which adds a runtime plan-guard refusal to Proc.exec (process replacement via execvp) so it cannot bypass the plan sandbox that Proc.spawn already enforces. I verified every other process-start path funnels through the guarded spawn helper, so this closes the only remaining bypass — a genuine hardening, not a new exposure. The remaining changes are test coverage (tests/Weir.Tests/Tests.fs) and a CI smoke-script assertion (ci/release-smoke.weir) that still validates no credential leakage while dropping the brittle ***-placeholder pin. No security vulnerabilities were introduced by this PR.

Updated for 4735b89.


Reviewed by Strix
Re-run review · Configure security review settings

@queil
queil merged commit 81f15bb into main Sep 24, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant