fix: wait for mcp doctor responses#177
Open
0xpolarzero wants to merge 1 commit into
Open
Conversation
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage ? 94.57%
=======================================
Files ? 27
Lines ? 3612
Branches ? 1435
=======================================
Hits ? 3416
Misses ? 162
Partials ? 34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0xpolarzero
force-pushed
the
fix/mcp-doctor-race
branch
from
18293c0 to
8d7c562
Compare
0xpolarzero
force-pushed
the
fix/mcp-doctor-race
branch
from
8d7c562 to
dbe3565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`mcp doctor` drives the in-process MCP server over `PassThrough` streams and closes input after a hardcoded 20ms. Under CI load the server hadn't flushed `tools/list` by then, so the smoke test intermittently failed with a missing `tools/list` response.
Wait for both responses (by request id) before closing input, instead of the fixed delay. The stream-end and serve-failure paths keep the negative cases terminating deterministically.