refactor(session): extract SSE response driver#655
Merged
Conversation
commit: |
parvahuja
force-pushed
the
parv/session-sse-driver
branch
from
a7212e1 to
450e6d5
Compare
parvahuja
force-pushed
the
parv/session-sse-driver
branch
from
450e6d5 to
56e59c6
Compare
brendanjryan
approved these changes
Jul 15, 2026
| driver, | ||
| input, | ||
| onReceipt, | ||
| return iterateSseMessages({ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionManager.sse()behavior unchangedMotivation
The existing SSE path projected responses directly into message strings, so fetch integrations could not reuse session payment handling while preserving an SSE response. This internal driver separates those concerns without changing the public API.
Validation
VITE_TEMPO_NETWORK=none pnpm exec vp test --run src/tempo/session/client/Transports.test.ts src/tempo/session/client/SessionManager.test.tsVITE_TEMPO_NETWORK=none pnpm exec vp test --run src/tempo/sessionpnpm check:typespnpm check:ci