fix(tempo): randomize expiring nonce hashes#4858
Merged
Merged
Conversation
|
@decofe is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 0addb10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| 'viem': patch | ||
| --- | ||
|
|
||
| Randomize `validAfter` for Tempo expiring-nonce transactions to prevent otherwise-identical transactions from sharing a nonce hash. |
Collaborator
There was a problem hiding this comment.
is this not "randomize validAfter if not set"?
Collaborator
There was a problem hiding this comment.
I odn't think we are providing a global jitter
jxom
approved these changes
Jul 18, 2026
jxom
left a comment
jxom
left a comment
Member
There was a problem hiding this comment.
The sponsored integration regression now exercises distinct hashes and successful receipts without mocking randomness.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tempo expiring transactions currently default to the same
nonceKey,nonce,validAfter, andvalidBefore. Identical calldata prepared within the same second therefore produces the same expiring nonce hash, which can leave subsequent sponsored requests blocked behind an in-flight transaction.This sets a random, already-valid
validAfterwhen Viem selects an expiring nonce, while preserving an explicitly supplied value. The regression test uses deterministic randomness to verify otherwise-identical sponsored requests receive distinct values.Validation:
biome check src/tempo/chainConfig.ts src/tempo/chainConfig.test.ts .changeset/random-lions-smile.mdoxsubmodule build is not included; CI will exercise the regression test in the complete checkout.Prompted by: @jxom