fix(unit): delegate parse/format unit utils to Ox's Value module#4859
Merged
Conversation
Fixes #4855. `parseUnits` rounded long fractional tails with `Math.round(Number(...))`, which is not exact for IEEE-754 doubles and could round the wrong way (e.g. parseUnits('1.4499999999999999999', 1) returned 15n instead of 14n). Reuses Ox's `Value` module (`from`/`format`/`fromEther`/`fromGwei`/ `formatEther`/`formatGwei`), which rounds exactly in decimal space, and adds regression tests for the reported cases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5AhB5FfyPaJLykDnV8Eqi
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4855.
parseUnitsrounded long fractional tails withMath.round(Number(...)), which is not exact for IEEE-754 doubles andcould round the wrong way (e.g. parseUnits('1.4499999999999999999', 1)
returned 15n instead of 14n).
Reuses Ox's
Valuemodule (from/format/fromEther/fromGwei/formatEther/formatGwei), which rounds exactly in decimal space, andadds regression tests for the reported cases.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Y5AhB5FfyPaJLykDnV8Eqi