Add i18n override coverage for single- and multi-select labels/ARIA text#2
Merged
wfabr merged 1 commit intoJun 11, 2026
Conversation
Copilot created this pull request from a session on behalf of
wfabr
June 11, 2026 15:06
View session
Owner
|
Superseded by PR #1, which now includes the i18n override tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds targeted test coverage for the recently introduced i18n override props on select components, ensuring customizable user-facing and accessibility strings are actually reflected in rendered output.
Scope: new i18n assertions in existing test suites
src/vscode-multi-select/vscode-multi-select.test.tssrc/vscode-single-select/vscode-single-select.test.tsdescribeblocks.vscode-multi-select: covered override behaviorsselected-textupdates badge text for both non-zero and zero selected states.open-button-aria-labelupdates combobox togglearia-label.no-options-textis rendered for empty filter results.create-option-prefixupdates creatable placeholder text.select-all-title/deselect-all-titleupdate tooltip titles for bulk action controls.accept-button-textupdates accept button label.vscode-single-select: covered override behaviorsno-options-textis rendered for empty filter results.create-option-prefixupdates creatable placeholder text.open-button-aria-labelupdates combobox togglearia-label.Example of the new assertion pattern: