feat: Changed to aware timezone on scheduled_function, swapped if/else to remove empty body. - #3
Open
GabrielZilioti wants to merge 1 commit into
Open
Conversation
…e to remove empty body.
GabrielZilioti
marked this pull request as draft
November 21, 2022 13:53
Author
GabrielZilioti
marked this pull request as ready for review
November 21, 2022 13:55
moff4
reviewed
Nov 26, 2022
|
|
||
| # check if the function should run based on whether or not the current timestamp | ||
| # meets or exceeds the next run timestamp | ||
| current_timestamp: float = datetime.now().timestamp() |
There was a problem hiding this comment.
should not here be current_timestamp also be UTC ?
on line 88(82) ur are comparing current_timestamp (which is not UTC) with scheduled_function.last_run (with is UTC) + cron delta. looks like bug, no?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I've made a few minor improvements on the code, like using aware timezone.