Skip to content

fix: preserve requirement text and standalone document scope in v0.5.6 - #4

Open
HyeonsangKim wants to merge 1 commit into
mainfrom
codex/release-v0.5.6
Open

HyeonsangKim wants to merge 1 commit into
mainfrom
codex/release-v0.5.6

Conversation

@HyeonsangKim

Copy link
Copy Markdown
Contributor

Requirement imports could turn unit_price * quantity into unitprice quantity and treat different bodies as identical when reusing verification evidence. Standalone screen specifications and handoffs also inherited a bundle-validation path that required unrequested companion files.

This patch preserves literal requirement text and internal whitespace, invalidates evidence when those bodies change, and limits bundle validation to explicitly requested numbered artifact sets. It releases v0.5.6 with English/Korean notes and a validation log.

All nine Core skills, including explicit-only verified-delivery, remain available. Knowledge Wiki changes only its manifest version under the shared-version policy. The experimental skill-removal and WorkGraph overview changes are excluded.

Validation:

  • bash scripts/validate.sh passed the full repository/plugin/skill and deterministic regression suite.
  • New literal-content tests reject the released importer and pass with this patch; they cover list/table content and evidence reuse/invalidation.
  • A WorkGraph CLI initimport smoke check preserved identifiers and multiplication.
  • Scope checks confirm version-only manifest changes and byte-identical verified-delivery files.

Previously corrupted saved imports require re-import and verification. Generated IDs or evidence reuse can change when previously normalized text is preserved. No new model benchmark was run, and this release claims no GPT-6 performance improvement.

@wigtn-contact

Copy link
Copy Markdown

판정: 승인

변경된 파일:

  • README.md
  • docs/RELEASE-v0.5.6-KO.md
  • docs/RELEASE-v0.5.6.md
  • docs/release-v0.5.6-validation.log
  • plugins/wigtn-knowledge-wiki/.codex-plugin/plugin.json
  • plugins/wigtn-plugins-with-codex/.codex-plugin/plugin.json
  • plugins/wigtn-plugins-with-codex/scripts/import-requirements.py
  • plugins/wigtn-plugins-with-codex/skills/screen-spec/SKILL.md
  • plugins/wigtn-plugins-with-codex/skills/screen-spec/references/handoff-contract.md
  • scripts/check-requirement-import.py
  • scripts/check-screen-contract.py

확인한 내용:

  • importer가 식별자, 연산자, backtick, 별표, 밑줄, 내부 공백과 음수 값을 보존하고, 실제 본문 변경 시 이전 검증 근거를 무효화하는 경로를 확인했습니다.
  • screen-spec과 handoff 지침이 standalone 산출물에는 묶음 validator를 강제하지 않고, 명시적으로 요청된 번호형 WIGTN 묶음에만 의존성 검사를 적용하도록 변경된 것을 확인했습니다.
  • 기존 형식별 importer, resume/drift 동작, 화면 계약 회귀 범위와 버전 manifest 변경을 확인했습니다.
  • 차단할 동작·계약·실패 경로 문제를 찾지 못했습니다.

검증

  • 방법: CI
  • 명령/체크: gh pr checks 4 --repo wigtn/wigtn-plugins-codex
  • 결과: 통과
  • 근거: Repository contract pass (run 35507168972, job 106068839518). 추가로 로컬에서 bash scripts/validate.sh를 실행해 저장소 계약, 화면 계약, requirement import, WorkGraph 및 정적 validation 전체가 통과했습니다.

검토한 head SHA: 5d7d1d41fe7c71d28f8e5134b0febfafc97fde5a

이 리뷰가 도움이 됐으면 👍, 지적이 틀렸으면 👎 를 눌러주세요. 오탐 집계에 씁니다.

@wigtn-contact wigtn-contact left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 사항을 확인했으며 차단할 문제가 없습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants