fix: remove PII console.log from edit-resolution handler#80
Open
bmersereau wants to merge 5 commits into
Open
Conversation
…Handler → handleEditResolution) Closes willchen96#94
amal66
added a commit
to amal66/mike
that referenced
this pull request
May 25, 2026
Chapter: 06 - Privacy-aware logging. Plain-English map: Replace ad hoc console logging with structured logger calls and remove log lines that exposed user/document activity identifiers. Why it matters: Legal-document activity is sensitive. Logs often flow to third-party systems, so they should contain only what is useful for debugging and operations. Principle: Minimize sensitive data. Treat logs as production data, not scratch paper. Precedent borrowed: Upstream PR willchen96#80 and GDPR-style data-minimization practice. Upstream base: willchen96/mike@d39f580. Original local commit: 9398be6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.logcalls from thehandleEditResolutionhandler that emitteduserId,documentId,editId, and internal state at INFO levelconsole.errorcalls in other handlers (storage, conversion) are untouched — those are genuine failure signalssrc/**/__tests__/**from TypeScript compilation so test-only ESM syntax doesn't break the builddocument_editsUPDATE calls that were silently swallowed after log removalresolveEditHandler, now correctly targetshandleEditResolution)Closes #71
Closes #86
Closes #94
Changes
backend/src/routes/documents.ts— allconsole.logstatements removed fromhandleEditResolution; DB error handling restored for both UPDATE callsbackend/tsconfig.json— test directories excluded from tsc includebackend/src/lib/__tests__/editResolutionLogging.test.ts— 3 static-analysis tests verifying no PII in handler source; function name correctedTest plan