Open
Conversation
Contributor
Author
|
I used the existing dev dependency on |
- add metadata that allows npmjs.com to link back to the repository - add an optional peer dependency on intl-messageformat so that tools being strict about dependency access (pnpm, Yarn PnP mode) can be supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intl-messageformatso that tools being strict about dependency access (pnpm, Yarn PnP mode) can be supported (relates to intl-messageformat dependency missing #336)To make the package even better, it might make sense to create a
README.md, as npmjs.com will render it.Regarding the
intl-messageformat, I'm actually wondering whether it should be defined as a required dependency instead (and then probably a normal dependency, not a peer one) as the way the UMD wrapper is defined does not make it optional when using CommonJS or RequireJS (therequire()is always done):BazingaJsTranslationBundle/Resources/js/translator.js
Lines 5 to 18 in 6fbd01d