[alloc] Reimplement ghost_tree avl operations iteratively instead of recurisively (Rust)#11
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reimplements key AVL tree operations used by the GhostTree allocator to be iterative rather than recursive, aiming to reduce recursion-driven stack usage and better support future atomic/thread-safe work while preserving behavior.
Changes:
- Reworked GhostTree AVL insert and best-fit remove to record traversal paths and rebalance iteratively.
- Added an iterative “remove-min” helper to support two-child removals without recursion.
- Converted inorder walk and balanced-tree rebuild steps to iterative stack/ops-driven implementations (Rust and C).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/alloc/ghost_tree.rs | Replaces recursive AVL traversal/rebalance logic with iterative path recording; updates inorder walk and rebuild to iterative forms. |
| c/bstack_alloc.c | Mirrors the iterative AVL insert/best-fit/remove-min/inorder-walk/build logic in the C implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplementing AVL operations in GhostTreeBStackAllocator iteratively
Description: Reimplementing AVL operations in GhostTreeBStackAllocator iteratively instead of recursively to minimize stack usage and provide better opportunity for lock-free, atomic, and thread-safe optimizations under the
atomicfeature flag in future prs. The implementation should behave identical to the recursive implementation.Important Feature: No
Type: Allocator - Reimplementation
Magic Number: ALGT
Bulk: No
Tests: Included
Feature Flags: alloc + set
Breaking change: No
New Types: None
Rust Only: No
Fuzz: Yes
Safety Review: Needed: Crash Safety, Invariants