Skip to content

[alloc] Reimplement ghost_tree avl operations iteratively instead of recurisively (Rust)#11

Merged
williamwutq merged 4 commits into
masterfrom
atomic
Jun 3, 2026
Merged

[alloc] Reimplement ghost_tree avl operations iteratively instead of recurisively (Rust)#11
williamwutq merged 4 commits into
masterfrom
atomic

Conversation

@williamwutq
Copy link
Copy Markdown
Owner

@williamwutq williamwutq commented Jun 3, 2026

Reimplementing AVL operations in GhostTreeBStackAllocator iteratively

Description: Reimplementing AVL operations in GhostTreeBStackAllocator iteratively instead of recursively to minimize stack usage and provide better opportunity for lock-free, atomic, and thread-safe optimizations under the atomic feature flag in future prs. The implementation should behave identical to the recursive implementation.

Important Feature: No
Type: Allocator - Reimplementation
Magic Number: ALGT
Bulk: No
Tests: Included
Feature Flags: alloc + set
Breaking change: No
New Types: None
Rust Only: No
Fuzz: Yes
Safety Review: Needed: Crash Safety, Invariants

@williamwutq williamwutq self-assigned this Jun 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reimplements key AVL tree operations used by the GhostTree allocator to be iterative rather than recursive, aiming to reduce recursion-driven stack usage and better support future atomic/thread-safe work while preserving behavior.

Changes:

  • Reworked GhostTree AVL insert and best-fit remove to record traversal paths and rebalance iteratively.
  • Added an iterative “remove-min” helper to support two-child removals without recursion.
  • Converted inorder walk and balanced-tree rebuild steps to iterative stack/ops-driven implementations (Rust and C).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/alloc/ghost_tree.rs Replaces recursive AVL traversal/rebalance logic with iterative path recording; updates inorder walk and rebuild to iterative forms.
c/bstack_alloc.c Mirrors the iterative AVL insert/best-fit/remove-min/inorder-walk/build logic in the C implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/alloc/ghost_tree.rs Outdated
Comment thread src/alloc/ghost_tree.rs Outdated
Comment thread src/alloc/ghost_tree.rs Outdated
Comment thread src/alloc/ghost_tree.rs Outdated
williamwutq and others added 2 commits June 2, 2026 22:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@williamwutq williamwutq marked this pull request as ready for review June 3, 2026 18:27
Copy link
Copy Markdown
Owner Author

@williamwutq williamwutq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamwutq williamwutq merged commit e5620c1 into master Jun 3, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants