feat: add adaptive plugin editor support#2
Closed
willkill07 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
Owner
Author
|
Closing in favor of opening this stacked PR on NVIDIA/NeMo-Flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stacked PR on top of NVIDIA/NeMo-Flow#128 (
wkk_enable-adaptive-plugin). This PR targetswkk_enable-adaptive-pluginand should be reviewed after or alongside NVIDIA#128.Adds
nemo-flow plugins editsupport for Adaptive plugin configuration options without exposing the default adaptive schemaversionas an operator-edited field.Details
agent_id,state.backend,telemetry,adaptive_hints,tool_parallelism,acg,acg.stability_thresholds, andpolicy.plugins.tomleditor flow.version = 1out of editor-created and editor-saved adaptive config.Validation run:
cargo fmt --allcargo test -p nemo-flow-cli plugins::testscargo test -p nemo-flow-adaptive test_adaptive_editor_schema_covers_canonical_optionscargo clippy -p nemo-flow-cli --all-targets -- -D warningsgit diff --checkWhere should the reviewer start?
Start with
crates/cli/src/plugins.rsfor the stacked editor flow. Then reviewcrates/adaptive/src/config.rsfor the Adaptive editor metadata. This PR is stacked against NVIDIA/NeMo-Flow#128; compare againstwkk_enable-adaptive-pluginfor the focused diff.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)