fix(cypher): preserve aggregate input with max rows - #14
Open
zgqq wants to merge 1 commit into
Open
Conversation
Signed-off-by: zgqq <zgqjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_rowsfrom truncating rows before aggregate evaluationmax_rowsas a final result-row limitCOUNTwithmax_rowssmaller than the matched input setVerification
cypher_apply_limit FAIL: "30" != "50"cypher_apply_limit PASSmake -j$(nproc) -f Makefile.cbm cbmmax_rows=10:MATCH (n) RETURN count(n)returns685instead of10The full local test runner has one environment-sensitive pre-existing failure in
incr_full_index: RSS delta 2545 MiB exceeds its fixed 2048 MiB threshold. No other test failed.Signed-off-by: zgqq zgqjava@gmail.com