Skip to content

feat(Drive): In app audio player (WPB-25408) - #5056

Merged
ohassine merged 27 commits into
developfrom
in-app-audio-palyer
Jul 24, 2026
Merged

feat(Drive): In app audio player (WPB-25408)#5056
ohassine merged 27 commits into
developfrom
in-app-audio-palyer

Conversation

@ohassine

@ohassine ohassine commented Jul 14, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-25408


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Screen_recording_20260714_141545.mp4

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine added 18 commits May 13, 2026 19:46
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/imageviewer/CellImageViewerNavArgs.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/imageviewer/CellImageViewerScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/imageviewer/CellImageViewerViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt
#	features/cells/src/main/res/values/strings.xml
#	kalium
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsMetroViewModelBindings.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelFactory.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelGraph.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/videoplayer/VideoPlayerScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/videoplayer/VideoPlayerViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/videoplayer/VideoViewerNavArgs.kt
#	gradle/libs.versions.toml
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.71014% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@bb69973). Learn more about missing BASE report.
⚠️ Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...id/feature/cells/ui/CellsMetroViewModelBindings.kt 0.00% 5 Missing ⚠️
.../android/feature/cells/ui/CellsViewModelFactory.kt 0.00% 4 Missing ⚠️
...com/wire/android/feature/cells/ui/CellViewModel.kt 25.00% 3 Missing ⚠️
...ature/cells/ui/audioplayer/AudioPlayerViewModel.kt 96.00% 0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (79.71%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5056   +/-   ##
==========================================
  Coverage           ?   49.78%           
==========================================
  Files              ?      662           
  Lines              ?    24107           
  Branches           ?     3748           
==========================================
  Hits               ?    12001           
  Misses             ?    10974           
  Partials           ?     1132           
Files with missing lines Coverage Δ
...wire/android/feature/cells/ui/CellScreenContent.kt 0.00% <ø> (ø)
...feature/cells/ui/audioplayer/AudioPlaybackState.kt 100.00% <100.00%> (ø)
.../wire/android/feature/cells/ui/model/CellNodeUi.kt 90.58% <100.00%> (ø)
...ature/cells/ui/audioplayer/AudioPlayerViewModel.kt 96.00% <96.00%> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 45.82% <25.00%> (ø)
.../android/feature/cells/ui/CellsViewModelFactory.kt 0.00% <0.00%> (ø)
...id/feature/cells/ui/CellsMetroViewModelBindings.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb69973...f301009. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohassine
ohassine requested a review from saleniuk July 21, 2026 13:33
@ohassine
ohassine requested a review from saleniuk July 22, 2026 11:59

@saleniuk saleniuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

2 102 tests   2 102 ✅  1m 46s ⏱️
  229 suites      0 💤
  229 files        0 ❌

Results for commit f301009.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine
ohassine added this pull request to the merge queue Jul 24, 2026
Merged via the queue into develop with commit 0d7708e Jul 24, 2026
20 of 21 checks passed
@ohassine
ohassine deleted the in-app-audio-palyer branch July 24, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants