Chore: Source refactor - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates dependencies in the
stellar-live-source-datalakeGo module and refactors howLedgerCloseMetais converted to the protobuf type. The most important changes are the adoption of a shared conversion core to prevent drift between services, and a comprehensive update to dependency versions for improved compatibility and security.Dependency Updates:
go.mod, includinggoversion (to 1.25.4),google.golang.org/grpc(to 1.80.0), and many indirect dependencies such ascloud.google.com/go,aws-sdk-go-v2,prometheus, andopentelemetrypackages. These updates improve compatibility, security, and performance. [1] [2] [3]github.com/withObsrvr/stellar-raw-ledger-origin v0.2.0for shared raw ledger conversion logic.Code Refactoring for Consistency:
server.goto import the shared raw ledger conversion core (rawledgercore) and delegate the conversion fromLedgerCloseMetatoRawLedgerto this shared module. This ensures consistent conversion logic across services and reduces maintenance overhead. [1] [2]Protocol Buffer Mapping:
sequenceandledger_close_meta_xdr) from the shared core to the service's protobuf type, omitting fields not present in the service's proto (like network passphrase and closed_at).