Skip to content

Chore: Source refactor - #87

Merged
tmosleyIII merged 2 commits into
mainfrom
chore/tmosley/query-cleanup-source-improvements
Jul 1, 2026
Merged

Chore: Source refactor#87
tmosleyIII merged 2 commits into
mainfrom
chore/tmosley/query-cleanup-source-improvements

Conversation

@tmosleyIII

Copy link
Copy Markdown
Contributor

This pull request updates dependencies in the stellar-live-source-datalake Go module and refactors how LedgerCloseMeta is converted to the protobuf type. The most important changes are the adoption of a shared conversion core to prevent drift between services, and a comprehensive update to dependency versions for improved compatibility and security.

Dependency Updates:

  • Upgraded core dependencies in go.mod, including go version (to 1.25.4), google.golang.org/grpc (to 1.80.0), and many indirect dependencies such as cloud.google.com/go, aws-sdk-go-v2, prometheus, and opentelemetry packages. These updates improve compatibility, security, and performance. [1] [2] [3]
  • Added the new dependency github.com/withObsrvr/stellar-raw-ledger-origin v0.2.0 for shared raw ledger conversion logic.

Code Refactoring for Consistency:

  • Updated server.go to import the shared raw ledger conversion core (rawledgercore) and delegate the conversion from LedgerCloseMeta to RawLedger to this shared module. This ensures consistent conversion logic across services and reduces maintenance overhead. [1] [2]

Protocol Buffer Mapping:

  • The conversion now explicitly maps only the common fields (sequence and ledger_close_meta_xdr) from the shared core to the service's protobuf type, omitting fields not present in the service's proto (like network passphrase and closed_at).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@tmosleyIII
tmosleyIII merged commit 6b46cae into main Jul 1, 2026
1 check passed
@tmosleyIII
tmosleyIII deleted the chore/tmosley/query-cleanup-source-improvements branch July 1, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants