Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughExtracts a shared ChangesPlatformIO Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@platformio.ini`:
- Line 427: The environment [env:esp01_1m_full_160] still overrides
custom_usermods with "audioreactive" instead of using the shared variable;
update its custom_usermods assignment to use ${common.default_usermods}
(matching the other envs) so changes to the central variable propagate, and
verify that the common.default_usermods definition exists and contains
"audioreactive" where intended.
- Around line 133-136: The global default_usermods list currently includes
audioreactive which is unsupported on ESP8266 and is pulled into ESP8266
environments; remove audioreactive from the global default_usermods, create a
new variable (e.g., common.default_usermods_esp32) that includes audioreactive
for ESP32/S2/S3/C3 envs, and update the ESP32-family environments to use
${common.default_usermods_esp32} while ensuring ESP8266 envs keep the original
default_usermods without audioreactive so CI/release builds for ESP8266 do not
include the unsupported module.
- Around line 133-136: The change adds a global default_usermods list
(default_usermods containing audioreactive, multi_relay, Temperature) in
platformio.ini which violates WLED guidelines and also makes audioreactive
active for ESP8266 where it is unsupported; revert the change in platformio.ini
and instead add these usermods to platformio_override.ini (or make them
conditional) so they only apply to intended environments, and if audioreactive
must be present ensure it is excluded from ESP8266 builds (e.g., move it behind
an ESP32-only override or conditional entry) and document any maintainer
approval for modifying global config on the PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b75d98a4-d781-48ca-a27c-d3bd913cc3fe
📒 Files selected for processing (1)
platformio.ini
|
The list of mods is more of a proposal for discussion rather than final list If we did include Temperature, we need to also change the usermod to be disabled by default Do we think the MultiRelay is popular enough to include or are the stats being distorted by the early adopters? Should we hold that back for 16.1 ? |
|
I would not add them by default. Multi-relay is used by quinled and maybe other hardware, it eats up 8k of flash (!) probably because it pulls in a library for I2C port expander. If we make it a default, it should be slimmed down to common use cases. |
|
ToDO: not matter which usermods we finally pick - we need to check them for "pin stealing" problems.
|
This pull request updates the
platformio.iniconfiguration to centralize and standardize the definition of custom user modules across multiple build environments. The main change is the introduction of adefault_usermodsvariable, which is then referenced throughout the configuration to ensure consistency and simplify future maintenance.Centralization of usermod configuration:
default_usermodsvariable under[common], listingaudioreactive,multi_relay, andTemperatureas default user modules.custom_usermods = ${common.default_usermods}instead of specifying user modules individually, replacing previous direct assignments likecustom_usermods = audioreactive. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]This change improves maintainability by ensuring that updates to the default user modules only need to be made in a single location.
Summary by CodeRabbit