fix(Fix_unreachable_netservices_v2): v16 compatibility fixes#5589
Closed
Joeboyc2 wants to merge 74 commits into
Closed
fix(Fix_unreachable_netservices_v2): v16 compatibility fixes#5589Joeboyc2 wants to merge 74 commits into
Joeboyc2 wants to merge 74 commits into
Conversation
Updated instructions for providing references in analysis results.
Eliminates size limit. Fixes wled#5458
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
replaces the last remaining FastLED.h with fstled_slim.h
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix leak in blockRouterAdvertisements
Fix Alexa/Hue discovery by correcting SSDP response to match UPnP spec
New extended data for usage report
Serialize fxdata without ArduinoJSON
Rather than append a linker file, we edit the upstream supplied ones to add our section to the binaries. Works better on all platforms. Co-Authored-By: Claude <noreply@anthropic.com>
Use readelf instead of nm for great speed.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0.16 - Backport dynarray fixes from V5 WIP
…h) (wled#5499) * use memory aligned allocations, fix bug in FFT magnitude (integer path) * assign pointer to globals not local copy
- fix PS Sparkler for large setups: need 32bit random position, 16bit is not enough - fix PS Fireworks 1D: need to `break` if no particles are available or it can lead to stalls on large setups - do not use collisions by default PS Fuzzy Noise: its very slow on larger setups
Add identifier string for DMX realtime mode
* fix blending style options list filter for iOS * fix default fallback
Added a guideline to prevent agents from overwriting PR descriptions (see https://github.com/orgs/community/discussions/187027).
some files were a bit behind - make sure the same instructions apply everywhere.
Emphasize the importance of targeting the main branch for PRs.
Palette display names now follow the format "UMName: palName" (e.g. "AudioReactive: Audio Responsive Hue") when a usermod supplies a specific palName, keeping the usermod name as a consistent prefix. Fallback when palName is nullptr remains "UMName index". Update AudioReactive palette names to the full descriptive names from the original WLED-MM port: "Audio Responsive Ratio", "Audio Responsive Hue", and "Audio Responsive Spectrum".
Since the display format is now "UMName: palName", shorten the palette names to just "Ratio", "Hue", and "Spectrum" — rendering as "AudioReactive: Ratio" etc. rather than "AudioReactive: Audio Responsive Ratio".
Move the four HUB75 envs from platformio_override.sample.ini into platformio.ini (refactored with a shared [hub75] section and extends= to deduplicate), and gate them behind a release-only config template so nightly/PR CI keep building only the standard env matrix. The release workflow now copies platformio_release.ini.template into place, which extends default_envs with the HUB75 envs.
Free PSRAM (info.psram) can be transiently 0 on PSRAM-capable boards, which would wrongly reject multi-panel HUB75 setups in the LED settings validation. Prefer info.psrSz (total PSRAM size) and fall back to info.psram only if psrSz is unavailable. Suggested in PR wled#5558 review.
…sage in getNumberOfPins logic
…t-profiles Add Ethernet profiles for QuinLED Dig-Uno/Quad v4 and Dig-Octa 32-8L v4
…rrent background color when Complete is enabled (wled#5453) * Fixes issue in Dissolve when a palette has same color pixel as the current background color when Complete mode is enabled --------- Co-authored-by: Damian Schneider <daedae@gmx.ch>
Two issues prevent this usermod from building under v16:
1. library.json is missing "build": {"libArchive": false}, causing the
build system to reject it with an error before compilation begins.
2. serializeConfig() no longer has a no-argument overload in v16; the
correct replacement is serializeConfigToFS() which creates the JSON
document internally and writes to the filesystem.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. Warning Ignoring CodeRabbit configuration file changes. For security, only the configuration from the base branch is applied for open source repositories. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (69)
WalkthroughAdds usermod palette ID space/APIs, HUB75 configs and UI gating, stricter E1.31/DDP parsing with length propagation, gzipped OTA validation/status model, shared UI pin utilities across settings, assorted FX and core tweaks, updated Ethernet options, new build/release workflows and envs, and extensive developer docs and CodeRabbit config. ChangesWLED v16 Integration Cohort
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches⚔️ Resolve merge conflicts
|
Contributor
Author
|
Closing in favour of a conflict-free replacement PR based directly on upstream/main. |
coderabbitai
Bot
added
bug
usermod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues prevent
Fix_unreachable_netservices_v2from building under WLED v16:Missing
libArchive: falseinlibrary.json— the v16 build system requires"build": {"libArchive": false}in every usermod'slibrary.json. Without it the build fails immediately withERROR: libArchive=false is missing on usermod(s).serializeConfig()no longer has a no-argument overload — v16 changedserializeConfig()to require aJsonObjectparameter. The correct no-argument replacement for saving config to the filesystem isserializeConfigToFS().Test plan
Fix_unreachable_netservices_v2compiles cleanly in an ESP8266 build environment with both fixes appliedserializeConfigToFS()is the correct equivalent — it allocates the JSON document internally and callsserializeConfig(root)+ writes to LittleFS🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
Improvements
Bug Fixes
Documentation