Make imports work regardless of cwd, add gitignore#4
Open
liliolett wants to merge 1 commit intowmannis:masterfrom
Open
Make imports work regardless of cwd, add gitignore#4liliolett wants to merge 1 commit intowmannis:masterfrom
liliolett wants to merge 1 commit intowmannis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
After installing the program i noticed that due to how python resolves local modules, i could only run lexifer from the source directory.
To remedy this, i modified the program to automatically change to its source directory before local imports, then return to the caller's working directory afterwards so that relative paths can still be used for the input file.
On my linux system this works as intended.
While i was at it, i also created a
.gitignorefile to stop the__pycache__directory from showing up as untracked.I hope these changes are helpful :)